Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix g2c_dec_png and make png grid size configurable #558

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from

Conversation

AlysonStahl-NOAA
Copy link
Contributor

@AlysonStahl-NOAA AlysonStahl-NOAA commented Nov 19, 2024

Fixes #557

This PR also contains some fixes to the g2c_dec_png() function. We want wgrib2 to work with g2c decoders and wgrib2 needs to support larger girds. I've tested these changes with wgrib2 and everything now works as expected.

@AlysonStahl-NOAA
Copy link
Contributor Author

The spack check is failing for an unrelated reason (Issue #559). All checks are successful if I either remove the check at the end or set spack-ref to an older version.

@edwardhartnett
Copy link
Contributor

We need a test of this change. That is, a test which would fail without this change, but passes with it.

@AlexanderRichert-NOAA
Copy link
Contributor

Re: #559, can you try changing self.builder.build_directory to self.build_directory in package.py? It sounds like this just recently changed in Spack. If that doesn't work I can investigate further.

@AlysonStahl-NOAA
Copy link
Contributor Author

Re: #559, can you try changing self.builder.build_directory to self.build_directory in package.py? It sounds like this just recently changed in Spack. If that doesn't work I can investigate further.

Unfortunately I tried that already and that didn't work.

@AlysonStahl-NOAA
Copy link
Contributor Author

We need a test of this change. That is, a test which would fail without this change, but passes with it.

Done. Both changes have a test that breaks if I remove them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make max png size configurable to support large grids.
3 participants